PMD Results

The following document contains the results of PMD 4.2.5.

Files

net/sf/jperfprobe/DefaultProbe.java

ViolationLine
Parameter 'name' is not assigned and could be declared final63
Parameter 'name' is not assigned and could be declared final68
Parameter 'tim' is not assigned and could be declared final68
Avoid variables with short names like ti99
Local variable 'ti' could be declared final99
Parameter 'time' is not assigned and could be declared final149

net/sf/jperfprobe/MockTime.java

ViolationLine
Parameter 'time' is not assigned and could be declared final40

net/sf/jperfprobe/ProbeManager.java

ViolationLine
Avoid variables with short names like p72
Avoid variables with short names like p115

net/sf/jperfprobe/ProbeManagerImpl.java

ViolationLine
Perhaps 'unit' could be replaced by a local variable.56
Avoid variables with short names like u58
Parameter 'timeFactor' is not assigned and could be declared final58
Parameter 'u' is not assigned and could be declared final58
Avoid unused private fields such as 'rLock'.92
Avoid unused private fields such as 'wLock'.93
Document empty constructor101 - 102
Parameter 'time' is not assigned and could be declared final112
Parameter 'presentation' is not assigned and could be declared final112
Parameter 'firstSamplesToSkip' is not assigned and could be declared final112
Parameter 'probeName' is not assigned and could be declared final125
Parameter 'probe' is not assigned and could be declared final125
Parameter 'probeName' is not assigned and could be declared final136
Parameter 'probeName' is not assigned and could be declared final167
Local variable 'result' could be declared final168
Parameter 'probeName' is not assigned and could be declared final188
Avoid variables with short names like p189
Local variable 'p' could be declared final189
Parameter 'probeName' is not assigned and could be declared final195
Local variable 'result' could be declared final196
Parameter 'probeName' is not assigned and could be declared final214
Local variable 'result' could be declared final215
Avoid variables with short names like p236
Parameter 'p' is not assigned and could be declared final236
Avoid variables with short names like r237
Local variable 'r' could be declared final237
Parameter 'probeName' is not assigned and could be declared final246
Parameter 'probeName' is not assigned and could be declared final265
Parameter 'probeName' is not assigned and could be declared final278
Avoid variables with short names like p296
Parameter 'p' is not assigned and could be declared final296
Parameter '_firstSamplesToSkip' is not assigned and could be declared final311
Parameter 'tim' is not assigned and could be declared final329
Parameter 'probe' is not assigned and could be declared final343
Avoid variables with short names like p344
Local variable 'p' could be declared final344
Parameter 'probe' is not assigned and could be declared final358
Local variable 'names' could be declared final368
Local variable 'ret' could be declared final369

net/sf/jperfprobe/Result.java

ViolationLine
The field name indicates a constant but its modifiers do not51
Variables that are not final should not contain underscores (except for underscores in standard prefix/suffix).51
Variables should start with a lowercase character51
Parameter 'name' is not assigned and could be declared final85
Parameter 'name' is not assigned and could be declared final89
Parameter 'nSkip' is not assigned and could be declared final89
Local variable 'dest' could be declared final95
Local variable 'nMinus1' could be declared final130
Local variable 'numerator' could be declared final131
Parameter 'probe' is not assigned and could be declared final150
Parameter 'time' is not assigned and could be declared final199
Parameter 'singleProbe' is not assigned and could be declared final236

net/sf/jperfprobe/StaticProbeManager.java

ViolationLine
Parameter 'probeName' is not assigned and could be declared final56
Parameter 'probe' is not assigned and could be declared final56
Parameter 'probeName' is not assigned and could be declared final67
Parameter 'probeName' is not assigned and could be declared final87
Parameter 'probeName' is not assigned and could be declared final96
Parameter 'probeName' is not assigned and could be declared final100
Parameter 'probeName' is not assigned and could be declared final109
Avoid variables with short names like p118
Parameter 'p' is not assigned and could be declared final118
Avoid variables with short names like p148
Parameter 'p' is not assigned and could be declared final148
Parameter '_firstSamplesToSkip' is not assigned and could be declared final162
Parameter 'tim' is not assigned and could be declared final180
Parameter 'probe' is not assigned and could be declared final190
Parameter 'probe' is not assigned and could be declared final200

net/sf/jperfprobe/TimeFactory.java

ViolationLine
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.3 - 16
Local variable 'version' could be declared final6
Local variable 'minor' could be declared final7